refactor(eslint-plugin): migrate to TS-ESLint infrastructure #7276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7276--docusaurus-2.netlify.app/ |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Size Change: 0 B Total Size: 806 kB ℹ️ View Unchanged
|
slorber
reviewed
May 4, 2022
| version "5.21.0" | ||
| resolved "https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-5.21.0.tgz#51d7886a6f0575e23706e5548c7e87bce42d7c18" | ||
| resolved "https://registry.npmmirror.com/@typescript-eslint/utils/-/utils-5.21.0.tgz#51d7886a6f0575e23706e5548c7e87bce42d7c18" |
There was a problem hiding this comment.
is this npmmirror change expected?
There was a problem hiding this comment.
Oh, thanks for noticing🤦♂️ I usually remember to revert the resolution before pushing, but forgot this time. It will be corrected next weekend when I bump dependencies.
It's mostly benign. npmmirror is trustable.
If we migrate to Yarn v3 (#6028), the resolved registry URL will not be in the lockfile.
Josh-Cena
added
the
pr: internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Continuation of #7206. This is in the spirit of #5817. It's also hugely helpful because all AST information will now be strictly encoded in the types.
Test Plan
All unit tests still pass