Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): make focused link outlined with JS disabled #6505

Merged
merged 1 commit into from Feb 3, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Fix partially #6411. A better fix would be to use :focus-visible where available and only fall back to using JS when the former is not available, but can't be bothered now.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Turn off JS and use tabs to navigate the page. Compare the behavior to the prod website.

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jan 29, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 29, 2022
@netlify
Copy link

netlify bot commented Jan 29, 2022

✔️ [V2]

🔨 Explore the source changes: 3643aaf

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61f4f6ff027b870007aa404d

😎 Browse the preview: https://deploy-preview-6505--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 72
🟢 Accessibility 100
🟢 Best practices 93
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6505--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +103 B (0%)

Total Size: 755 kB

Filename Size Change
website/build/assets/js/main.********.js 573 kB +70 B (0%)
website/build/index.html 30.1 kB +33 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 47 kB
website/build/assets/css/styles.********.css 105 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Feb 3, 2022

LGTM 👍

@slorber slorber merged commit 01c6f15 into main Feb 3, 2022
@slorber slorber deleted the jc/link-focus branch February 3, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants