New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix highlighting of YAML front matter #6206
Conversation
✔️ [V2] 🔨 Explore the source changes: bff3699 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61ca9b3bd877d1000907377b 😎 Browse the preview: https://deploy-preview-6206--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6206--docusaurus-2.netlify.app/ |
Size Change: +5.25 kB (+1%) Total Size: 667 kB
ℹ️ View Unchanged
|
great, thanks 👍 Also noticed that our dark prism theme doesn't highlight yml well, not sure if we should change our theme or fix the existing one |
Ah, I was just wondering if we want to try out However, that means we would need to update the init templates as well so users don't come and ask "why do I have different themes from the official website"... |
In terms of "fixing the existing one", I think there's little we can do right now. If we forked |
I'm not against switching the dark theme, including in the init templates. Is it really better in most cases? Is it popular/well-maintained? It's quite subjective.
The themes are just json files with some type/color bindings, so technically it could be possible to extend an existing theme easily. For this specific case, it seems pushing a Note: I'm not sure In this specific case we mostly want to fix our own doc, not everyone's doc. Not everyone needs yaml syntax highlighting 😅 but at the same time, the darcula theme seems quite less featured compared to the light github one, so maybe we should just change, not sure by which one to replace it though. Maybe we should create our own official prism theme package, eventually extending the existing ones we use? |
Motivation
See PrismJS/prism#3283
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Check out a page with markdown front matter in code blocks; they are now rendered properly.