Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme-classic): add outline to focused code blocks #6121

Merged
merged 2 commits into from
Dec 18, 2021
Merged

fix(theme-classic): add outline to focused code blocks #6121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dd9ab0
fix(theme-classic): add outline to focused code blocks
christopherklint97 Dec 17, 2021
267caa1
refactor: remove opacity
christopherklint97 Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/docusaurus-theme-classic/src/theme/CodeBlock/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
margin-bottom: var(--ifm-leading);
border-radius: var(--ifm-global-radius);
box-shadow: var(--ifm-global-shadow-lw);
overflow: hidden;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently I added this in #5215, don't remember why 😅 hope it's safe to remove

Copy link
Collaborator

@Josh-Cena Josh-Cena Dec 18, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized what overflow: hidden does... Because if we set border radius on the parent container but child is still a regular rectangle, the child overflows and makes the code block still appear as a sharp-edged rectangle. The reason that the highlight doesn't appear on FF is also because they treat the highlight as part of overflow and gets hidden

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I remember that was related to border-radius now 😅 it was simpler to add radiuses on the container than on the individual items, particularly when the live codeblock playground/result positions are configurable

}

.codeBlockContent {
Expand Down