Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade html-webpack-plugin, remove terser 4 #5761

Merged
merged 1 commit into from Oct 21, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Oct 21, 2021

Motivation

jantimon/html-webpack-plugin#1688

Upgrade html-webpack-plugin, ensuring all our deps are using Terser 5, preventing once for all some issues we had in monorepos where Terser 4+5 co-existed (#3515).

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview builds

@slorber slorber requested a review from lex111 as a code owner October 21, 2021 15:39
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 21, 2021
@netlify
Copy link

netlify bot commented Oct 21, 2021

✔️ [V2]

🔨 Explore the source changes: bbb97ff

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61718a1cda0f190007842a8d

😎 Browse the preview: https://deploy-preview-5761--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 96
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5761--docusaurus-2.netlify.app/

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Oct 21, 2021
@github-actions
Copy link

Size Change: +6 B (0%)

Total Size: 844 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 38.2 kB 0 B
website/build/assets/css/styles.********.css 93.8 kB 0 B
website/build/assets/js/main.********.js 426 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 67.7 kB 0 B
website/build/blog/index.html 38.5 kB 0 B
website/build/docs/index.html 45.7 kB +3 B (0%)
website/build/docs/installation/index.html 53.4 kB +3 B (0%)
website/build/index.html 31.2 kB 0 B
website/build/tests/docs/index.html 26.8 kB 0 B
website/build/tests/docs/standalone/index.html 23.3 kB 0 B

compressed-size-action

@slorber slorber merged commit ef246da into main Oct 21, 2021
@slorber slorber deleted the slorber/remove-terser-4 branch October 21, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants