Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make tags wrapping properly #5422

Merged
merged 1 commit into from Aug 26, 2021
Merged

fix: make tags wrapping properly #5422

merged 1 commit into from Aug 26, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Aug 26, 2021

Motivation

The current tags layout is poorly suited for multiple long tags, need to fix this.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

tags: [release, i18n, tag, long tag, long long tag, long-long-long tag, another tag]
Before After
image image

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Aug 26, 2021
@lex111 lex111 requested a review from slorber as a code owner August 26, 2021 09:26
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 26, 2021
@netlify
Copy link

netlify bot commented Aug 26, 2021

✔️ [V2]

🔨 Explore the source changes: 934f46c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61275e4f3ab19f0007731d07

😎 Browse the preview: https://deploy-preview-5422--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 96
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5422--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +39 B (0%)

Total Size: 812 kB

Filename Size Change
website/build/blog/index.html 35.8 kB +42 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 36.2 kB 0 B
website/build/assets/css/styles.********.css 94.9 kB +4 B (0%)
website/build/assets/js/main.********.js 410 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 65.8 kB 0 B
website/build/docs/index.html 43.1 kB -3 B (0%)
website/build/docs/installation/index.html 50.7 kB -4 B (0%)
website/build/index.html 29.8 kB 0 B
website/build/tests/docs/index.html 24.1 kB 0 B
website/build/tests/docs/standalone/index.html 21.9 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Aug 26, 2021

👍 thanks

@slorber slorber merged commit 22eebea into main Aug 26, 2021
@slorber slorber deleted the lex111/tags-fix-mul branch August 26, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants