Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove top margin only from directly first element #5240

Merged
merged 1 commit into from Aug 11, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jul 29, 2021

Motivation

Fix small UI bug after #5230 because currently top margin is also removed in first element inside mobile TOC.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before After
image image

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Jul 29, 2021
@lex111 lex111 requested a review from slorber as a code owner July 29, 2021 06:48
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 29, 2021
@github-actions
Copy link

Size Change: -6 B (0%)

Total Size: 905 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 71.3 kB 0 B
website/build/assets/css/styles.********.css 93.4 kB 0 B
website/build/assets/js/main.********.js 495 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.5 kB 0 B
website/build/blog/index.html 26.4 kB 0 B
website/build/docs/index.html 40.6 kB -3 B (0%)
website/build/docs/installation/index.html 48.2 kB -3 B (0%)
website/build/index.html 27.4 kB 0 B
website/build/tests/docs/index.html 21.2 kB 0 B
website/build/tests/docs/standalone/index.html 19.1 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Jul 29, 2021

✔️ [V2]

🔨 Explore the source changes: 54a4d9e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61024f271c8bb8000761c463

😎 Browse the preview: https://deploy-preview-5240--docusaurus-2.netlify.app

@lex111
Copy link
Contributor Author

lex111 commented Aug 11, 2021

Think, it's safe for merge right now.

@lex111 lex111 merged commit 0c73afd into master Aug 11, 2021
@lex111 lex111 deleted the lex111/docitem-actia branch August 11, 2021 06:47
@slorber
Copy link
Collaborator

slorber commented Aug 11, 2021

yes 😅 forgot some pending PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants