Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): update Infima to alpha 26 #5001

Merged
merged 1 commit into from
Jun 18, 2021
Merged

chore(v2): update Infima to alpha 26 #5001

merged 1 commit into from
Jun 18, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jun 18, 2021

Motivation

Resolves #3820 (in most cases this will be enough to fix this since we have truncated the navbar title and reduced spacing between navbar items).

Fixes #3937

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Jun 18, 2021
@lex111 lex111 requested a review from slorber as a code owner June 18, 2021 10:48
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 18, 2021
@@ -6,9 +6,6 @@
padding: calc(var(--ifm-global-spacing) / 2) var(--ifm-global-spacing);
color: var(--ifm-color-emphasis-900);
background-color: var(--ifm-background-surface-color);
border-radius: var(--ifm-global-radius);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not directly related to updating Infima, just removing unnecessary styles and adding shadow to the skip link (see above).

@netlify
Copy link

netlify bot commented Jun 18, 2021

✔️ [V2]

🔨 Explore the source changes: fe3c445

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60cc79f5e4261600078e0c94

😎 Browse the preview: https://deploy-preview-5001--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 71
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5001--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +302 B (0%)

Total Size: 625 kB

Filename Size Change
website/build/assets/css/styles.********.css 87.8 kB +222 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 63.4 kB +53 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/build/assets/js/main.********.js 445 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 28.1 kB +27 B (0%)

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Jun 18, 2021

👍

@slorber slorber merged commit 7dc9fe8 into master Jun 18, 2021
@slorber slorber deleted the lex111/infima-25 branch August 17, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
3 participants