feat(v2): add code block theming in init template #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
|
✔️ [V2] 🔨 Explore the source changes: 255cc1d 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60c7e7d833c8660007f4c1e3 😎 Browse the preview: https://deploy-preview-4968--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4968--docusaurus-2.netlify.app/ |
|
thanks 👍 |
slorber
added
pr: polish
valentine
added a commit
to valentine/docs.hackerspace.sg
that referenced
this pull request
Mar 5, 2023
valentine
added a commit
to valentine/docs.hackerspace.sg
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #4812. This makes the initialized site more closely resemble the Docusaurus website, because currently the light theme for code blocks seems broken, causing quite some confusion.
Have you read the Contributing Guidelines on pull requests?
Yep
Test Plan
The same configuration is used by the Docusaurus website, so it should be working.
The only thing I'm not sure of is that I had to
requireglobally to silence ESLint errors, while for new users it might be more straightforward torequireit within the object definition.