fix(v2): fix minor a11y issue with headings #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Built with commit 609fa51 |
|
[V2] Built with commit 609fa51 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4792--docusaurus-2.netlify.app/ |
|
Size Change: +16 B (0%) Total Size: 640 kB ℹ️ View Unchanged
|
As we use it in the classic theme, I think it probably make sense to add the package to the main repo? |
|
This can also be done, although it seemed to me that such remark plugin is better isolated in separated repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Actually it should have been done with the last Infima update, but I did not have time to mention it.
However we still have one a11y error (
h5) related with headings -- I want to fix this in our fork ofremark-admonitions(which will be placed in docusaurus organization, hopefully)Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview - no visual changes.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)