Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example for Github Pages deployment; rewrite deployment section #4409

Merged
merged 15 commits into from
Nov 7, 2021

Commits on Mar 12, 2021

  1. Configuration menu
    Copy the full SHA
    86e4abb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    634c047 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81ad1ac View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. docs: Minor gh-pages deploy config improvements

    Improve some comments and clarifies the file path beyond file name alone for each config file.
    
    Additionally removes the workflow path triggers as in practice these being updated shouldn't be triggering a re-run of the workflow again (assuming deterministic build from same input results in same output).
    
    If there is a need for such a manual trigger of the workflow is probably a better approach. Performing a build because workflow comments were modified only would be pointless for example.
    polarathene committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    d1ef6fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b02834e View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. chore: PR Feedback - Remove inline documentation

    Upstream doesn't see value including help comments for a copy/paste config under the basis that it adds friction to the viewer seeking guidance how to perform something they don't know.
    polarathene committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    43f97e9 View commit details
    Browse the repository at this point in the history
  2. chore: PR Feedback - Rephrase instruction

    MatanBobi requested a rephrase during review.
    polarathene committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    fcaa277 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2021

  1. Configuration menu
    Copy the full SHA
    decd2c4 View commit details
    Browse the repository at this point in the history
  2. Rewrite

    Josh-Cena committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    244229c View commit details
    Browse the repository at this point in the history
  3. Fixes

    Josh-Cena committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    d6ee05f View commit details
    Browse the repository at this point in the history
  4. Fix!

    Josh-Cena committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    cd1053a View commit details
    Browse the repository at this point in the history
  5. Format

    Josh-Cena committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    4fe37cb View commit details
    Browse the repository at this point in the history
  6. Fix indentation

    Josh-Cena committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    b20b4da View commit details
    Browse the repository at this point in the history
  7. Improvements

    Josh-Cena committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    7ca7c5d View commit details
    Browse the repository at this point in the history
  8. Minor fixes

    Josh-Cena committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    555e810 View commit details
    Browse the repository at this point in the history