-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add example for Github Pages deployment; rewrite deployment section #4409
Merged
Josh-Cena
merged 15 commits into
facebook:main
from
polarathene:docs/deploy-ghp-simplify
Nov 7, 2021
Merged
docs: add example for Github Pages deployment; rewrite deployment section #4409
Josh-Cena
merged 15 commits into
facebook:main
from
polarathene:docs/deploy-ghp-simplify
Nov 7, 2021
Commits on Mar 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 86e4abb - Browse repository at this point
Copy the full SHA 86e4abbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 634c047 - Browse repository at this point
Copy the full SHA 634c047View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81ad1ac - Browse repository at this point
Copy the full SHA 81ad1acView commit details
Commits on Mar 16, 2021
-
docs: Minor
gh-pages
deploy config improvementsImprove some comments and clarifies the file path beyond file name alone for each config file. Additionally removes the workflow path triggers as in practice these being updated shouldn't be triggering a re-run of the workflow again (assuming deterministic build from same input results in same output). If there is a need for such a manual trigger of the workflow is probably a better approach. Performing a build because workflow comments were modified only would be pointless for example.
Configuration menu - View commit details
-
Copy full SHA for d1ef6fb - Browse repository at this point
Copy the full SHA d1ef6fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b02834e - Browse repository at this point
Copy the full SHA b02834eView commit details
Commits on Mar 23, 2021
-
chore: PR Feedback - Remove inline documentation
Upstream doesn't see value including help comments for a copy/paste config under the basis that it adds friction to the viewer seeking guidance how to perform something they don't know.
Configuration menu - View commit details
-
Copy full SHA for 43f97e9 - Browse repository at this point
Copy the full SHA 43f97e9View commit details -
chore: PR Feedback - Rephrase instruction
MatanBobi requested a rephrase during review.
Configuration menu - View commit details
-
Copy full SHA for fcaa277 - Browse repository at this point
Copy the full SHA fcaa277View commit details
Commits on Nov 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for decd2c4 - Browse repository at this point
Copy the full SHA decd2c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 244229c - Browse repository at this point
Copy the full SHA 244229cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6ee05f - Browse repository at this point
Copy the full SHA d6ee05fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd1053a - Browse repository at this point
Copy the full SHA cd1053aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fe37cb - Browse repository at this point
Copy the full SHA 4fe37cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b20b4da - Browse repository at this point
Copy the full SHA b20b4daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ca7c5d - Browse repository at this point
Copy the full SHA 7ca7c5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 555e810 - Browse repository at this point
Copy the full SHA 555e810View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.