refactor(v2): use transform instead of top position for hideable navbar #4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
added
the
pr: polish
lex111
changed the title
|
[V1] Deploy preview success Built with commit 0a1e29a |
|
Deploy preview for docusaurus-2 ready! Built with commit 0a1e29a |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4194--docusaurus-2.netlify.app/classic/ |
|
Size Change: +14 B (0%) Total Size: 156 kB ℹ️ View Unchanged
|
lex111
changed the title
|
[V1] Deploy preview success Built with commit 31c57e2 |
|
Deploy preview for docusaurus-2 ready! Built with commit 31c57e2 |
|
LGTM 👍 |
|
oh :'( merged too fast it seems it broke the hamburger menu in production
Let me know if you want to fix it, otherwise, I'll do it before the end of the day (or revert) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Animating the
topproperty will have some graphics performance impacts, basically animating top will trigger the browser to perform layout operations.Instead use transform with translate3d so the operation can likely be carried out by the compositor thread with the help of the GPU.
As result, we get smoother transition (navbar hide animation) on mobiles:
UPD: As per the discussion in tailwindlabs/tailwindcss#1380, I changed
translateYtotranslate3dhttps://twitter.com/adamwathan/status/1280902295081926656Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)