Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc2.md #366

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Update doc2.md #366

merged 1 commit into from
Jan 12, 2018

Conversation

ppatel221
Copy link
Contributor

Motivation

(Write your motivation here.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@neilsutcliffe
Copy link
Contributor

Doesn't seem to be documented too well, but makes sense.

Are all markdown links relative to the root of the doc folder? There was a request to allow folders, but for now it is just a completely flat structure correct?

@ppatel221
Copy link
Contributor Author

I've checked through the other docs and the links are relative to the root of the doc folder.

@JoelMarcey
Copy link
Contributor

@ppatel221 Hi. Thanks! Can you please sign the CLA so we can merge this pull request?

@JoelMarcey
Copy link
Contributor

@neilsutcliffe Yes, right now we allow the docs in any folder you want, but they have to be in a flat file structure. There is a request to allow docs in a staggered structure, but we have some considerations to take into account before doing that.

I probably could update https://docusaurus.io/docs/en/doc-markdown.html to talk about links to other docs.

@ppatel221
Copy link
Contributor Author

I've just signed the CLA!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 4, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@JoelMarcey
Copy link
Contributor

I documented inter-document referencing in #394

Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppatel221 Thank you!

@JoelMarcey JoelMarcey merged commit 7864e1b into facebook:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants