fix(v2): Add optional-chaining and nullish-coalescing babel plugin #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 908f3e1 |
yangshun
approved these changes
Jun 17, 2020
SamChou19815
deleted the
add-optional-chaining-nullish-coalescing-plugins
branch
|
I think it also fixes #2908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
These plugins are necessary since we introduced some nullish coalescing syntax in #2884. See #2950 for the rationale. This PR is also needed for #2950 to be merged without CI error.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
./admin/scripts/test-release.sh cd test-website yarn startWithout this change, it will fail. With this change, website can correctly load.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)