Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): style sidebar on overflow #2034

Merged
merged 1 commit into from Nov 24, 2019
Merged

feat(v2): style sidebar on overflow #2034

merged 1 commit into from Nov 24, 2019

Conversation

endiliey
Copy link
Contributor

Motivation

This is continuation from #2017 but for left sidebar. Feel free to close if you think it's not looking nice

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

Before
before dark
before styling
before

After
after dark
after styling
after

@endiliey endiliey added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 23, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 23, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 4948060

https://deploy-preview-2034--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 4948060

https://deploy-preview-2034--docusaurus-preview.netlify.com

@yangshun yangshun merged commit 670fd4e into master Nov 24, 2019
@yangshun yangshun deleted the endi/sidebarstyle branch November 24, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants