Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v1): remove exclusive language #1961

Merged
merged 2 commits into from Nov 11, 2019
Merged

Conversation

eric-hc
Copy link
Contributor

@eric-hc eric-hc commented Nov 11, 2019

Motivation

Similar to jestjs/jest#9040 by @carolstran, I wanted to take a stab at removing some language (easy, simply, of course, etc) to continue creating a more inclusive and friendly community.

It was difficult, however, because a lot of Docusaurus' goal is...

Easy to maintain open source documentation websites

...so there were a lot branding references with the word "easy", so I kept those and also did not touch old blog posts.

Let me know what you think!

Have you read the Contributing Guidelines on pull requests?

Yes!

Test Plan

N/a no code changes

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot
Copy link
Contributor

Hi ericcarboni! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 11, 2019

Deploy preview for docusaurus-2 ready!

Built with commit e9520ac

https://deploy-preview-1961--docusaurus-2.netlify.com

@lex111
Copy link
Contributor

lex111 commented Nov 11, 2019

@ericcarboni why did you changes numbered lists?

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 11, 2019

Deploy preview for docusaurus-preview ready!

Built with commit e9520ac

https://deploy-preview-1961--docusaurus-preview.netlify.com

@eric-hc
Copy link
Contributor Author

eric-hc commented Nov 11, 2019

Whoops, my editor might have done that. Good catch!

@lex111
Copy link
Contributor

lex111 commented Nov 11, 2019

@ericcarboni can you revert these changes?

@eric-hc
Copy link
Contributor Author

eric-hc commented Nov 11, 2019

Yeah, doing that now. Any idea why some lists are 1...2... and then others are 1...1...1...?

@lex111
Copy link
Contributor

lex111 commented Nov 11, 2019

Any idea why some lists are 1...2... and then others are 1...1...1...?

I do not know this, but I would leave only one notation 1..1. Such lists are easier to maintain. But this already needs to be fixed in the new PR and it may be worthwhile to set linting MD files to avoid such a problem in the future.

@lex111 lex111 changed the title docs: remove inclusive language docs(v2): remove inclusive language Nov 11, 2019
@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 11, 2019
@eric-hc
Copy link
Contributor Author

eric-hc commented Nov 11, 2019

One instance even had 1..1..3 🤷‍♂

@lex111 lex111 changed the title docs(v2): remove inclusive language docs: remove inclusive language Nov 11, 2019
Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-hc eric-hc changed the title docs: remove inclusive language docs: remove exclusive language Nov 11, 2019
@eric-hc
Copy link
Contributor Author

eric-hc commented Nov 11, 2019

CLA signed! ✍️

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 11, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you so much! We will probably want to change our tagline to make it more inclusive.

@yangshun
Copy link
Contributor

yangshun commented Nov 11, 2019

One instance even had 1..1..3 🤷‍♂

That's probably because there was a code block or something between the second 1 and the 3. Doing 1..1..3 will result in 1, 2, 3. Doing 1..1..1 will cause it to become 1, 2, 1 instead because the numbers are reset after the code block.

@yangshun yangshun merged commit b027db1 into facebook:master Nov 11, 2019
@yangshun yangshun changed the title docs: remove exclusive language docs(v1): remove exclusive language Nov 11, 2019
@eric-hc eric-hc mentioned this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants