docs(v1): external links (#3011)

facebook · Jun 30, 2020 · 984e2d4 · 984e2d4
1 parent 2e055f4
commit 984e2d4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/docs/api-site-config.md b/docs/api-site-config.md
@@ -53,8 +53,8 @@ headerLinks: [
   { doc: "doc1", label: "Getting Started" },
   // Link to page found at pages/en/help.js or if that does not exist, pages/help.js, for current language
   { page: "help", label: "Help" },
-  // Links to href destination
-  { href: "https://github.com/", label: "GitHub" },
+  // Links to href destination, using target=_blank (external)
+  { href: "https://github.com/", label: "GitHub", external: true },
   // Links to blog generated by Docusaurus (${baseUrl}blog)
   { blog: true, label: "Blog" },
   // Determines search bar position among links

diff --git a/website-1.x/siteConfig.js b/website-1.x/siteConfig.js
@@ -27,6 +27,7 @@ const siteConfig = {
     {
       href: 'https://github.com/facebook/docusaurus',
       label: 'GitHub',
+      external: true,
     },
   ],
   headerIcon: 'img/docusaurus.svg',