fix(utils): remove non-ASCII limitation for path normalization (#8137)

facebook · Oct 7, 2022 · 6c8af03 · 6c8af03
1 parent efbd0cb
commit 6c8af03
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/packages/docusaurus-utils/src/__tests__/pathUtils.test.ts b/packages/docusaurus-utils/src/__tests__/pathUtils.test.ts
@@ -156,7 +156,7 @@ describe('posixPath', () => {
   it('works', () => {
     const asserts: {[key: string]: string} = {
       'c:/aaaa\\bbbb': 'c:/aaaa/bbbb',
-      'c:\\aaaa\\bbbb\\★': 'c:\\aaaa\\bbbb\\★',
+      'c:\\aaaa\\bbbb\\★': 'c:/aaaa/bbbb/★',
       '\\\\?\\c:\\aaaa\\bbbb': '\\\\?\\c:\\aaaa\\bbbb',
       'c:\\aaaa\\bbbb': 'c:/aaaa/bbbb',
       'foo\\bar': 'foo/bar',

diff --git a/packages/docusaurus-utils/src/pathUtils.ts b/packages/docusaurus-utils/src/pathUtils.ts
@@ -58,12 +58,7 @@ export function shortName(str: string): string {
 export function posixPath(str: string): string {
   const isExtendedLengthPath = str.startsWith('\\\\?\\');
 
-  // Forward slashes are only valid Windows paths when they don't contain non-
-  // ascii characters.
-  // eslint-disable-next-line no-control-regex
-  const hasNonAscii = /[^\u0000-\u0080]+/.test(str);
-
-  if (isExtendedLengthPath || hasNonAscii) {
+  if (isExtendedLengthPath) {
     return str;
   }
   return str.replace(/\\/g, '/');

diff --git a/website/_dogfooding/_docs tests/tests/ascii/folder/æøå.md b/website/_dogfooding/_docs tests/tests/ascii/folder/æøå.md
@@ -0,0 +1 @@
+Dogfood test for https://github.com/facebook/docusaurus/pull/8137
diff --git a/website/_dogfooding/_docs tests/tests/ascii/æøå/index.md b/website/_dogfooding/_docs tests/tests/ascii/æøå/index.md
@@ -0,0 +1 @@
+Dogfood test for https://github.com/facebook/docusaurus/pull/8137