Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slow recompile time #9911

Merged
merged 1 commit into from Oct 26, 2020
Merged

fix: slow recompile time #9911

merged 1 commit into from Oct 26, 2020

Conversation

FezVrasta
Copy link
Contributor

@FezVrasta FezVrasta commented Oct 26, 2020 •
edited

fixes #9886

This is the commit that removed the cache flag:
FezVrasta@d07b7d0#r43578777

@ianschmitz ianschmitz added this to the 4.0.1 milestone Oct 26, 2020
@ianschmitz ianschmitz merged commit ceeb654 into facebook:master Oct 26, 2020
@ianschmitz
Copy link
Contributor

Thanks for the fix!

@FezVrasta FezVrasta deleted the patch-5 branch October 26, 2020 18:18
@Saibamen Saibamen mentioned this pull request Oct 26, 2020
Closed
@osdiab
Copy link

osdiab commented Oct 30, 2020

Just wondering - since this is blocking me from upgrading CRA for my team, any thoughts on when a patch version with this change might be published to NPM? Thanks again for the fix!

@ianschmitz ianschmitz mentioned this pull request Oct 30, 2020
Closed
@pascalstr
Copy link

Please consider splitting the 4.0.1 release and ship what has been fixed already.

@apibrac apibrac mentioned this pull request Nov 9, 2020
Merged
@Hristijan95 Hristijan95 mentioned this pull request Nov 15, 2020
Closed
@ChristianIvicevic ChristianIvicevic mentioned this pull request Nov 16, 2020
Closed
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 20, 2020
@apibrac
(MOB): Correct eslint use of cache
abcaf86 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 20, 2020
@apibrac
(MOB): Correct eslint use of cache
f0befdb 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 21, 2020
@apibrac
(MOB): Correct eslint use of cache
76e7372 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 23, 2020
@apibrac
(MOB): Correct eslint use of cache
fc52a43 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 23, 2020
@apibrac
(MOB): Correct eslint use of cache
030ce88 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
@amcsi
Copy link

amcsi commented Nov 23, 2020

I tried upgrading to react-scripts 4.0.1, but it didn't seem to fix the slow fast refresh speed.

apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 23, 2020
@apibrac
(MOB): Correct eslint use of cache
4495ca4 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 23, 2020
@apibrac
(MOB): Correct eslint use of cache
1c06efd 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
apibrac added a commit to pass-culture/pass-culture-pro that referenced this pull request Nov 23, 2020
@apibrac
(MOB): Correct eslint use of cache
32e9171 
Correction following this correction on react-scripts facebook/create-react-app#9911 (merged)
Cache location inspired of what will certainly will be in react-scrips facebook/create-react-app#9977 (not merged at this time)
   but it doesn't really matter
@WojciechMatuszewski
Copy link

WojciechMatuszewski commented Nov 24, 2020 •
edited

Soo... AFAIK theeslint-webpack-plugin does not have the cache option. There were some performance concerns raised within the plugin repo but they were fixed with a new release. IMO, we should just bump the dependency, otherwise, everyone will be forced to use resolutions or patch-package.

This was referenced Dec 1, 2020
Closed
Closed
wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
@FezVrasta @wombleton
fix: slow recompile time (facebook#9911)
bd8fa7d 
fixes facebook#9886
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 19, 2023
@FezVrasta @abhiisheek
fix: slow recompile time (facebook#9911)
03c9d9a 
fixes facebook#9886
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
@FezVrasta @abhiisheek
fix: slow recompile time (facebook#9911)
b609d90 
fixes facebook#9886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.

Very slow recompile times (~20 seconds)
7 participants
@FezVrasta @ianschmitz @osdiab @pascalstr @amcsi @WojciechMatuszewski @facebook-github-bot