Add support for postcss.config.js #8907
Conversation
piecyk
requested review from
amyrlam,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Hi @piecyk! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
piecyk
force-pushed
the
feature/postcss-config
branch
from
fcd2292
to
b5c6338
Compare
|
What's the difference between this an #8331? |
piecyk
force-pushed
the
feature/postcss-config
branch
2 times, most recently
from
4d4bc0b
to
0d0c6be
Compare
|
Cool! Well hopefully this gets accepted. It would be nice to override the PostCSS config. |
piecyk
force-pushed
the
feature/postcss-config
branch
from
0d0c6be
to
93b1545
Compare
piecyk
force-pushed
the
feature/postcss-config
branch
2 times, most recently
from
f5223a9
to
0feb76b
Compare
…ptions - Update post-processing-css.md - Add test - Add postcss-load-config as react-scripts dependency
piecyk
force-pushed
the
feature/postcss-config
branch
from
0feb76b
to
384401a
Compare
|
Should be ready 👋 |
|
ping @ianschmitz @mrmckeb |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
Maybe not stale? 🤷♂️ |
|
I have everything crossed this makes it into the next version 🤞 |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
Please don't close this PR!! This would help us a lot. We are looking forward to see custom postcss configurations |
|
This would be a huge win, especially with recent popularity of Tailwind which requires a PostCSS configuration file. |
|
Is it possible to get any insight into when this could potentially be released? Soon? Next major release? |
|
This really helps a lot! |
|
It would be great that the user can in charge of the PostCSS build. |
|
This is a great feature! I was hoping to build it if it isn't initiated. |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
don't close this PR! |
|
Any update on this? |
@joshmanders I don’t see it happening anytime soon. That’s why I made a custom fork and implemented it myself. Using my fork with my cra-template-tailwindcss template is the way to go if you are looking for create react app with tailwind support 👍 |
|
@GeoffSelby oh I didn't know you made one. I keep checking back on CRA about having more support for things and see it's always just PR or Issue after PR/Issue with no updates or feedback. May as well just stay with Next.js |
|
Resolved via #10003 |
This pull request addressed the issue of supporting custom postcss.config.js. It's third one after #8474 #8331 🙈
Basic idea here is to check if we have config same way
postcss-loaderdoes.