Run git init before template dependencies are installed #8282
Conversation
lukaszfiszer
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Hi lukaszfiszer! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
This looks good to me, thanks @lukaszfiszer. I'll wait for another review and flag for the next minor.
| @@ -265,9 +280,10 @@ module.exports = function( | |||
| return; | |||
| } | |||
|
|
|||
| if (tryGitInit(appPath)) { | |||
| // Create git commit if git repo was initialized | |||
| if (initializedGit && tryGitCommit(appPath)) { | |||
There was a problem hiding this comment.
I'd probably break out tryGitCommit into another line and call it didCommit or something... but I think it's OK like this too.
As proposed in #8280, this PR moves initialization of git repository before installation of template dependencies.