Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpackHotDevClient.js to support WebSockets over SSL/TLS #8078

Closed
wants to merge 1 commit into from

Conversation

mikecaulley
Copy link
Contributor

Summary

  • If https protocol is being used we should use WebSockets over SSL/TLS (WSS) protocol instead of WebSockets (WS)

Test Plan
Follow steps in the issue #8075

@facebook-github-bot
Copy link

Hi mikecaulley! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@mikecaulley mikecaulley closed this Dec 5, 2019
@lock lock bot locked and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants