Switched to WorkboxWebpackPlugin.InjectManifest from WorkboxWebpackPlugin.GenerateSW

[MOZGIII]

Implementation for #7966

[facebook-github-bot]

Hi MOZGIII! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[MOZGIII]

Oh well, I guess It's quite a bit more difficult than I thought to do right.

[neolefty]

As a simplistic alternative, I've found this to work to exclude API endpoints from caching:

in package.json, add a sed step to build:

"build": "react-scripts build && sed -i -r -f serviceworker.sed build/service-worker.js"

Where serviceworker.sed contains a regex to insert /^\/(api|swagger)/, at the start of the blacklist:

# we can even add comments inside the sed file
s/(^.*blacklist\: \[)/\1\/\^\\\/\(api\|swagger\)\/,/

A hack to be sure, and I doubt it works on Windows.

[MOZGIII]

This looks good. It fits most of my simpler use cases nicely.
However, I started this work on service workers to address a more in-depth use case, and for that, it, unfortunately, won't be enough.

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[stale]

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!