Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launch.json for #5319 #6484

Merged
merged 1 commit into from Aug 8, 2019
Merged

Fix launch.json for #5319 #6484

merged 1 commit into from Aug 8, 2019

Conversation

ryan-mars
Copy link
Contributor

This fixes #5319

This PR was tested by:

  • create-react-app
  • Create .vscode/launch.json according to this page in the docs
  • Add the changes in this PR to .vscode/launch.json
  • Add various tests to src/App.test.js in an attempt to throw off the source maps
  • Set multiple break points
  • Start the debugger
  • See that the debugger in VS Code hits the correct lines

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Mar 23, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale
Copy link

stale bot commented Mar 29, 2019

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this Mar 29, 2019
@ryan-mars
Copy link
Contributor Author

Deep eye roll 🙄

@lock lock bot locked and limited conversation to collaborators Apr 3, 2019
@bugzpodder bugzpodder reopened this Jul 6, 2019
@stale stale bot removed the stale label Jul 6, 2019
@bugzpodder bugzpodder added this to the 3.0.2 milestone Jul 6, 2019
@iansu iansu merged commit cb2c720 into facebook:master Aug 8, 2019
@iansu
Copy link
Contributor

iansu commented Aug 8, 2019

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRA2 recommended config hits random break points in VS Code
4 participants