Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about serviceWorker.js #6069

Closed
wants to merge 1 commit into from
Closed

add note about serviceWorker.js #6069

wants to merge 1 commit into from

Conversation

jeffwillette
Copy link

I followed these instructions and converted all the js files to ts and it failed to compile. Added a note about serviceWorker.js needing to be converted to ts, or left as js

Copy link
Contributor

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffwillette
Copy link
Author

hmm. shouldn't the typed version be used by default if they are making a typescript app?

@petetnt
Copy link
Contributor

petetnt commented Jan 3, 2019

Actually I'd say yes, it could be a follow up for #5549

@stale
Copy link

stale bot commented Feb 7, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Feb 7, 2019
@stale
Copy link

stale bot commented Feb 12, 2019

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this Feb 12, 2019
@petetnt petetnt reopened this Feb 12, 2019
@stale stale bot removed the stale label Feb 12, 2019
@stale
Copy link

stale bot commented Mar 14, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@bugzpodder
Copy link

Thanks for the PR. we have this file now.

@bugzpodder bugzpodder closed this Aug 11, 2019
@lock lock bot locked and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants