Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link is broken on the website #5594

Closed
wants to merge 1 commit into from
Closed

Link is broken on the website #5594

wants to merge 1 commit into from

Conversation

Bnaya
Copy link

@Bnaya Bnaya commented Oct 27, 2018

this is a possible fix
Corrent link is leading to:
https://facebook.github.io/docs/deployment#building-for-relative-paths [broken]
And not to:
https://facebook.github.io/create-react-app/docs/deployment#building-for-relative-paths [good]

Not how to make it work also inside GH, as the .md file ext is missing and not added by default (?)

this is a possible fix
Corrent link is leading to:
https://facebook.github.io/docs/deployment#building-for-relative-paths [broken]
And not to:
https://facebook.github.io/create-react-app/docs/deployment#building-for-relative-paths [good]

Not how to make it work also inside GH, as the .md file ext is missing and not added by default (?)
@ehfeng
Copy link
Contributor

ehfeng commented Oct 29, 2018

I've opened a larger PR around this here: #5552

@Bnaya Bnaya closed this Oct 29, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants