Prevent the cache of files using Babel Macros #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timer
changed the title
iansu
approved these changes
Sep 24, 2018
loganfsmyth
reviewed
Sep 27, 2018
| caller: { | ||
| name: `babel-preset-react-app:${crypto | ||
| .randomBytes(32) | ||
| .toString('hex')}`, |
There was a problem hiding this comment.
I understand why you're using a random value, but there's no need to append it to the name. You can just make a new property like craInvalidationToken or something on caller.
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
* Add new overrides option * Add file to package.json * Create our own loader * Remove overrides * We have to use a real babel option * Add comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't cache files using babel macros until babel/babel#8497 is resolved.
Unfortunately we need to use our own loader until babel/babel-loader#687 is merged.