Update dependencies (To fix Babel bug) #3110
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Hello! I'm a bot that helps facilitate testing pull requests. Your pull request (commit aefa7fe) has been released on npm for testing purposes. npm i react-scripts-canary@1.0.14-aefa7fe.0
# or
yarn add react-scripts-canary@1.0.14-aefa7fe.0
# or
create-react-app --scripts-version=react-scripts-canary@1.0.14-aefa7fe.0 folder/Thanks for your contribution! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
We typically like to do bumps like this in major versions in case things break; I'll tag this for 2.0.0 -- thanks! |
|
I updated deps in a patch. This version has been out for a while and is probably safe. |
babel-plugin-transform-es2015-modules-commonjshas a serious bug about the following snippet and it is fixed inv6.26.0release.The problem is that current
create-react-appinstalls Babelv6.24.1. It should be updated.I'm not familiar with Babel and npm version resolution algorithm, however, I guess the reason;
babel-preset-react-appdoesn't use caret^versioning and select old versions. So we may use caret or update the versions. (This PR simply update versions)