Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved issue #2971 #2989

Merged
merged 3 commits into from Sep 13, 2017
Merged

Resolved issue #2971 #2989

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
849a95c
Resolved issue #2971
Aug 21, 2017
0081135
Added header tag to template
Aug 21, 2017
2603e02
Added className for App-title
Aug 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-scripts/template/src/App.css
View file
Open in desktop
Expand Up @@ -14,6 +14,10 @@
color: white;
}

.App-header h1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We intentionally don't have any tag-based selectors. Generally this is not recommended in React apps because those are very brittle. Can you please add an explicit className for it if this is necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback Dan! I pushed a commit with these changes.

font-size: 1.5em;
}

.App-intro {
font-size: large;
}
Expand Down
6 changes: 3 additions & 3 deletions packages/react-scripts/template/src/App.js
View file
Open in desktop
Expand Up @@ -6,10 +6,10 @@ class App extends Component {
render() {
return (
<div className="App">
<div className="App-header">
<header className="App-header">
<img src={logo} className="App-logo" alt="logo" />
<h2>Welcome to React</h2>
</div>
<h1>Welcome to React</h1>
</header>
<p className="App-intro">
To get started, edit <code>src/App.js</code> and save to reload.
</p>
Expand Down