Pass WDS_SOCKET options to webpack webSocketServer #13505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously these were being provided only in the `client.webSocketURL` key, which tells the client where to connect but doesn't actually adjust where the dev server will be listening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had trouble getting the
WDS_SOCKET_PATHoption to work with the react-scripts dev server - while the client was correctly attempting to connect to the path I specified, the backend was still just listening on/wsno matter what. Seems to be the same problem as #12092.I've tracked it down to the configuration being provided to the webpack dev server. The websocket connection options were being provided only in the
client.webSocketURLkey, which tells the client where to connect but doesn't actually adjust where the dev server will be listening - that is specified inwebSocketServer.optionsinstead.Making this change to
webpackDevServer.config.jsin mynode_modulesfixed the problem - after restarting the react dev server, the websocket was now listening at the correct path.