Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #13441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG-1.x.md
Expand Up @@ -961,7 +961,7 @@ yarn add --exact react-scripts@1.0.9
- [#2511](https://github.com/facebook/create-react-app/pull/2511) Support `.web.js` extension for React Native Web. ([@mini-eggs](https://github.com/mini-eggs))
- [#2645](https://github.com/facebook/create-react-app/pull/2645) Hide confusing "Skipping static resource" message. ([@gaearon](https://github.com/gaearon))
- [#2389](https://github.com/facebook/create-react-app/pull/2389) Silence unnecessary warning from Babel. ([@gaearon](https://github.com/gaearon))
- [#2429](https://github.com/facebook/create-react-app/pull/2429) Update `sw-precache-webpack-plugin` to lastest version. ([@goldhand](https://github.com/goldhand))
- [#2429](https://github.com/facebook/create-react-app/pull/2429) Update `sw-precache-webpack-plugin` to latest version. ([@goldhand](https://github.com/goldhand))
- [#2600](https://github.com/facebook/create-react-app/pull/2600) Add empty mock for `dgram` Node module. ([@micopiira](https://github.com/micopiira))
- [#2458](https://github.com/facebook/create-react-app/pull/2458) Add names to module factories in development. ([@Zaccc123](https://github.com/Zaccc123))
- [#2551](https://github.com/facebook/create-react-app/pull/2551) In new projects, unregister service worker and force reload if `service-worker.js` is not found. ([@ro-savage](https://github.com/ro-savage))
Expand Down Expand Up @@ -999,7 +999,7 @@ yarn add --exact react-scripts@1.0.9
- [#2044](https://github.com/facebook/create-react-app/pull/2044) Add React Styleguidist. ([@sapegin](https://github.com/sapegin))
- [#2006](https://github.com/facebook/create-react-app/pull/2006) Added instruction on how to install Prettier. ([@MrHus](https://github.com/MrHus))
- [#1813](https://github.com/facebook/create-react-app/pull/1813) Fix grammar. ([@iheng](https://github.com/iheng))
- [#2060](https://github.com/facebook/create-react-app/pull/2060) Add more info about OOM build failiure [docs]. ([@GAumala](https://github.com/GAumala))
- [#2060](https://github.com/facebook/create-react-app/pull/2060) Add more info about OOM build failure [docs]. ([@GAumala](https://github.com/GAumala))
- [#2305](https://github.com/facebook/create-react-app/pull/2305) Update docs with WebSocket proxy information. ([@jamesblight](https://github.com/jamesblight))
- [#2445](https://github.com/facebook/create-react-app/pull/2445) Document `REACT_EDITOR` environment variable. ([@wirmar](https://github.com/wirmar))
- [#2362](https://github.com/facebook/create-react-app/pull/2362) Add yarn example under "Installing a Dependency". ([@BrianDGLS](https://github.com/BrianDGLS))
Expand Down
4 changes: 2 additions & 2 deletions CHANGELOG-2.x.md
Expand Up @@ -625,7 +625,7 @@ yarn add --exact react-scripts@2.1.0
- [#4984](https://github.com/facebook/create-react-app/pull/4984) Use the correct dependency for `babel-plugin-dynamic-import-node`. ([@vikr01](https://github.com/vikr01))

- `react-scripts`
- [#5354](https://github.com/facebook/create-react-app/pull/5354) Add environment variable to optionaly disable inlining of chunks. ([@0xdeafcafe](https://github.com/0xdeafcafe))
- [#5354](https://github.com/facebook/create-react-app/pull/5354) Add environment variable to optionally disable inlining of chunks. ([@0xdeafcafe](https://github.com/0xdeafcafe))
- [#5330](https://github.com/facebook/create-react-app/pull/5330) Update `eslint-plugin-jsx-a11y` version. ([@AlmeroSteyn](https://github.com/AlmeroSteyn))

#### :memo: Documentation
Expand Down Expand Up @@ -1173,7 +1173,7 @@ If you used 2.x alphas, please [follow these instructions](https://gist.github.c
- [#4298](https://github.com/facebook/create-react-app/pull/4298) Added learnstorybook.com to Storybook links ([@tmeasday](https://github.com/tmeasday))
- [#4117](https://github.com/facebook/create-react-app/pull/4117) Document multiple build environments via `env-cmd` #4071 ([@jMuzsik](https://github.com/jMuzsik))
- [#4197](https://github.com/facebook/create-react-app/pull/4197) Add troubleshooting for Github Pages ([@xnt](https://github.com/xnt))
- [#4236](https://github.com/facebook/create-react-app/pull/4236) use the lastest url of gitignore file ([@Plortinus](https://github.com/Plortinus))
- [#4236](https://github.com/facebook/create-react-app/pull/4236) use the latest url of gitignore file ([@Plortinus](https://github.com/Plortinus))
- [#4239](https://github.com/facebook/create-react-app/pull/4239) Fix typo in comment and be clearer about `ecma` settings in uglifyjs options ([@danielberndt](https://github.com/danielberndt))
- [#4164](https://github.com/facebook/create-react-app/pull/4164) Fix typos in example monorepo documentation. ([@bradfordlemley](https://github.com/bradfordlemley))
- [#4089](https://github.com/facebook/create-react-app/pull/4089) Fix a typo in packages/react-scripts/template/README.md ([@nott](https://github.com/nott))
Expand Down
8 changes: 4 additions & 4 deletions CHANGELOG-3.x.md
Expand Up @@ -136,7 +136,7 @@ v3.4.0 is a minor release that adds new features, including support for SSL and

- `react-dev-utils`, `react-scripts`
- [#8442](https://github.com/facebook/create-react-app/pull/8442) fix(react-scripts): do not redirect served path if request may proxy ([@iamandrewluca](https://github.com/iamandrewluca))
- [#7259](https://github.com/facebook/create-react-app/pull/7259) feat(react-scripts): allow PUBLIC_URL in develoment mode ([@iamandrewluca](https://github.com/iamandrewluca))
- [#7259](https://github.com/facebook/create-react-app/pull/7259) feat(react-scripts): allow PUBLIC_URL in development mode ([@iamandrewluca](https://github.com/iamandrewluca))
- [#7750](https://github.com/facebook/create-react-app/pull/7750) Enable custom sockjs pathname for hot reloading server. ([@heygrady](https://github.com/heygrady))
- `cra-template-typescript`
- [#8412](https://github.com/facebook/create-react-app/pull/8412) Change arrow functions to function declarations ([@lewislbr](https://github.com/lewislbr))
Expand Down Expand Up @@ -462,7 +462,7 @@ We've removed this rule as it is not compatible with Prettier. If you rely on th
- `react-dev-utils`, `react-scripts`
- [#7972](https://github.com/facebook/create-react-app/pull/7972) Add placeholders where old template READMEs used to be ([@iansu](https://github.com/iansu))
- `babel-preset-react-app`
- [#7932](https://github.com/facebook/create-react-app/pull/7932) fix seperators typo ([@donavon](https://github.com/donavon))
- [#7932](https://github.com/facebook/create-react-app/pull/7932) fix separators typo ([@donavon](https://github.com/donavon))
- `react-dev-utils`
- [#7897](https://github.com/facebook/create-react-app/pull/7897) chore: Fix broken link for CRA deployment ([@haruelrovix](https://github.com/haruelrovix))
- `react-scripts`
Expand Down Expand Up @@ -609,7 +609,7 @@ v3.2.0 is a minor release that adds support for production profiling and ignorin
#### :memo: Documentation

- [#7302](https://github.com/facebook/create-react-app/pull/7302) docs: note that 2 to 3 migration may require deletion of node_modules ([@kimpers](https://github.com/kimpers))
- [#7757](https://github.com/facebook/create-react-app/pull/7757) Documentation typo fix: accessbile→accessible ([@tomer](https://github.com/tomer))
- [#7757](https://github.com/facebook/create-react-app/pull/7757) Documentation typo fix: accessible→accessible ([@tomer](https://github.com/tomer))
- [#7601](https://github.com/facebook/create-react-app/pull/7601) [Documentation] Updated list of supported Jest config overrides ([@neilbryson](https://github.com/neilbryson))
- [#7705](https://github.com/facebook/create-react-app/pull/7705) Update runtime chunk name separator in docs ([@samuelmeuli](https://github.com/samuelmeuli))

Expand Down Expand Up @@ -865,7 +865,7 @@ v3.1.0 is a minor release that adds ESLint 6 support as well as experimental sup
- [#7317](https://github.com/facebook/create-react-app/pull/7317) Fix typo ([@mvasin](https://github.com/mvasin))
- [#7262](https://github.com/facebook/create-react-app/pull/7262) Docs: replace the command line to install relay/macro ([@soufDev](https://github.com/soufDev))
- [#7170](https://github.com/facebook/create-react-app/pull/7170) Update deprecated package reference ([@bnewcomb](https://github.com/bnewcomb))
- [#7133](https://github.com/facebook/create-react-app/pull/7133) Make the OOM abreviation more clear ([@tlehtimaki](https://github.com/tlehtimaki))
- [#7133](https://github.com/facebook/create-react-app/pull/7133) Make the OOM abbreviation more clear ([@tlehtimaki](https://github.com/tlehtimaki))
- [#7086](https://github.com/facebook/create-react-app/pull/7086) Improve breaking changes info for CRA 3.0.0 ([@falldowngoboone](https://github.com/falldowngoboone))
- [#7059](https://github.com/facebook/create-react-app/pull/7059) Correct spelling of browserslist ([@amyrlam](https://github.com/amyrlam))
- [#7039](https://github.com/facebook/create-react-app/pull/7039) docs: fix env-cmd example in deployment section ([@VMois](https://github.com/VMois))
Expand Down
2 changes: 1 addition & 1 deletion packages/react-dev-utils/getPublicUrlOrPath.js
Expand Up @@ -13,7 +13,7 @@ module.exports = getPublicUrlOrPath;

/**
* Returns a URL or a path with slash at the end
* In production can be URL, abolute path, relative path
* In production can be URL, absolute path, relative path
* In development always will be an absolute path
* In development can use `path` module functions for operations
*
Expand Down
4 changes: 2 additions & 2 deletions packages/react-error-overlay/src/containers/StackTrace.js
Expand Up @@ -10,7 +10,7 @@ import React, { Component } from 'react';
import StackFrame from './StackFrame';
import Collapsible from '../components/Collapsible';
import { isInternalFile } from '../utils/isInternalFile';
import { isBultinErrorName } from '../utils/isBultinErrorName';
import { isBuiltinErrorName } from '../utils/isBultinErrorName';

import type { StackFrame as StackFrameType } from '../utils/stack-frame';
import type { ErrorLocation } from '../utils/parseCompileError';
Expand Down Expand Up @@ -40,7 +40,7 @@ class StackTrace extends Component<Props> {
stackFrames.forEach((frame, index) => {
const { fileName, _originalFileName: sourceFileName } = frame;
const isInternalUrl = isInternalFile(sourceFileName, fileName);
const isThrownIntentionally = !isBultinErrorName(errorName);
const isThrownIntentionally = !isBuiltinErrorName(errorName);
const shouldCollapse =
isInternalUrl && (isThrownIntentionally || hasReachedAppCode);

Expand Down
Expand Up @@ -6,7 +6,7 @@
*/

/* @flow */
function isBultinErrorName(errorName: ?string) {
function isBuiltinErrorName(errorName: ?string) {
switch (errorName) {
case 'EvalError':
case 'InternalError':
Expand All @@ -21,5 +21,5 @@ function isBultinErrorName(errorName: ?string) {
}
}

export { isBultinErrorName };
export default isBultinErrorName;
export { isBuiltinErrorName };
export default isBuiltinErrorName;
Expand Up @@ -11,7 +11,7 @@ const filePathRegex = /^\.(\/[^/\n ]+)+\.[^/\n ]+$/;

const lineNumberRegexes = [
// Babel syntax errors
// Based on syntax error formating of babylon parser
// Based on syntax error formatting of babylon parser
// https://github.com/babel/babylon/blob/v7.0.0-beta.22/src/parser/location.js#L19
/^.*\((\d+):(\d+)\)$/,

Expand Down
Expand Up @@ -94,7 +94,7 @@ Object {
Failed to compile.

./src/App.js
Cannot find file './ThisFileSouldNotExist' in './src'.
Cannot find file './ThisFileShouldNotExist' in './src'.


",
Expand Down
@@ -1,5 +1,5 @@
import React, { Component } from 'react';
import DefaultExport from './ThisFileSouldNotExist';
import DefaultExport from './ThisFileShouldNotExist';

class App extends Component {
render() {
Expand Down