fix(babel-preset-react-app): add missing dependency #12364
Conversation
|
This fix is already in #11751. |
|
True, but why hasn't that PR been merged? It's been 5 months. |
eventualbuddha
force-pushed
the
add-@babel/plugin-proposal-private-property-in-object-dependency
branch
from
be1134e
to
6d37be4
Compare
|
Anyone coming to this later, it appears this bug was introduced in 10.0.1, so using 10.0.0 works around the issue. I'd still like to see this fixed, but given that 10.0.1 was released 6 months ago and 10.0.0 two years ago I don't see that as terribly likely. |
I'm assuming the maintainers are lacking the bandwidth to review it. |
As a maintainer of various projects that I can only make time for here and there, I get it. But since 10.0.0 doesn't have this issue (and I can use pnpmfile.js to work around it in 10.0.1) I'm not really upset. That said, this is an easy one to review so if any maintainers want a quick win, here it is 😄 |
Actually if you're using |
|
Any chance this could be merged? |
|
@indutny I don't think this will ever be fixed. I recommend switching to vite like I did. |
In facebook#11318 a change was made to `babel-preset-react-app` to require `@babel/plugin-proposal-private-property-in-object`, but no such dependency was added to `package.json`. This fixes that mistake by adding the dependency.
robhogan
force-pushed
the
add-@babel/plugin-proposal-private-property-in-object-dependency
branch
from
6d37be4
to
59663b7
Compare
|
Looks like this old bug is highlighted by a recent Babel update, which means pre-existing CRA projects are breaking on semver-minor Babel bumps - babel/babel#15655. I'm not a regular maintainer here but as this is a straightforward fix, I'm merging it. @iansu / @gaearon / @rickhanlonii, what do we need to do get a patch release out? |
eventualbuddha
deleted the
add-@babel/plugin-proposal-private-property-in-object-dependency
branch
|
Hi @robhogan , hope you are doing well. It took almost a year to merge this issue... however, do you see the fix to be release soon. ? |
Running the latest version of Storybook logged a warning during
building:
One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in
your node_modules folder for unrelated reasons, but it may break at
any time.
babel-preset-react-app is part of the create-react-app project,
which is not maintianed anymore. It is thus unlikely that this bug
will ever be fixed. Add
"@babel/plugin-proposal-private-property-in-object" to your
devDependencies to work around this error. This will make this
message go away.
As the warning indicates, this is a known issue in create-react-app[1],
which was actually fixed[2], but there has not been a release with that
fix.
Add the plugin to our devDependencies to work around the issue. Long
term, we need to figure out what to do about create-react-app.
[1] facebook/create-react-app#13325
[2] facebook/create-react-app#12364
Running the latest version of Storybook logged a warning during
building:
One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in
your node_modules folder for unrelated reasons, but it may break at
any time.
babel-preset-react-app is part of the create-react-app project,
which is not maintianed anymore. It is thus unlikely that this bug
will ever be fixed. Add
"@babel/plugin-proposal-private-property-in-object" to your
devDependencies to work around this error. This will make this
message go away.
As the warning indicates, this is a known issue in create-react-app[1],
which was actually fixed[2], but there has not been a release with that
fix.
Add the plugin to our devDependencies to work around the issue. Long
term, we need to figure out what to do about create-react-app.
[1] facebook/create-react-app#13325
[2] facebook/create-react-app#12364
In facebook#11318 a change was made to `babel-preset-react-app` to require `@babel/plugin-proposal-private-property-in-object`, but no such dependency was added to `package.json`. This fixes that mistake by adding the dependency.
In facebook#11318 a change was made to `babel-preset-react-app` to require `@babel/plugin-proposal-private-property-in-object`, but no such dependency was added to `package.json`. This fixes that mistake by adding the dependency.
In #11318 a change was made to
babel-preset-react-appto require@babel/plugin-proposal-private-property-in-object, but no such dependency was added topackage.json. This fixes that by adding the dependency.