Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webpack hanging under certain circumstance, use process.exitCode… #12292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexxyzeng
Copy link

sometimes i found out react-scripts buld hangs under certain circumstances, like:
81ae142a7d27fafa6e422f0f81b49f2
when i changed process.exit(1) to process.exitCode = 1, it can end up with failure:
3ee6070794b767f955ca547ec3270fb

According to https://nodejs.org/dist/latest-v16.x/docs/api/process.html#processexitcode_1:

Rather than calling process.exit() directly, the code should set the process.exitCode and allow the process to exit naturally by avoiding scheduling any additional work for the event loop:

I also find that webpack and webpack-cli also have simlar issues fixed:
fix: fix webpack hanging under certain circumstance
Fix webpack hanging under certain circumstance, use process.exitCode instead of process.exit in compilerCallback
misc(refactor): reduce code duplication use process.exitCode instead of process.exit

@facebook-github-bot
Copy link

Hi @alexxyzeng!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants