fix: fast refresh stops on needed bail outs #11105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast Refresh requires the HMR runtime to support bail out behaviour (we do not do so within the core runtime as it has to be platform agnostic) - and currently webpackHotDevClient does not do so properly as it circumvents the logic for forced reloads completely when using Fast Refresh. The changes done here ensures that: - If Fast Refresh is not enabled, we would always bail out to a forced reload; - If Fast Refresh is enabled and there are updated modules, it indicates the update has at least partially executed, and we can rely on Fast Refresh being resilient to errors and skip the forced reload; - If Fast Refresh is enabled and there are none updated modules, it indicates the update cannot be executed without being inconsistent (i.e. Fast Refresh bailed out), we would bail out to a forced reload.
pmmmwh
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
This was referenced Jun 15, 2021
|
Updated heuristic to cover more cases (to be on the safe side) where we would force a reload, especially when Webpack signifies that the HMR update is aborted or failed completely (indicating applying the update would yield inconsistency). |
|
Thanks! Looking forward to getting these enhancements out in v5! |
Merged
sumanthratna
pushed a commit
to sumanthratna/create-react-app
that referenced
this pull request
Aug 4, 2021
This was referenced Jul 7, 2022
abhiisheek
pushed a commit
to abhiisheek/create-react-app
that referenced
this pull request
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast Refresh requires the HMR runtime to support bail out behaviour (we do not do so within the core runtime as it has to be platform agnostic) - and currently webpackHotDevClient does not do so properly as it circumvents the logic for forced reloads completely when using Fast Refresh.
The changes done here ensures that:
abortorfailed, it indicates the update cannot be executed without being inconsistent (i.e. Fast Refresh bailed out), we would bail out to a forced reload.To verify the impact of this change:
App.jswith multiple exports (e.g. [BUG]: Silently fails with multiple exports pmmmwh/react-refresh-webpack-plugin#426)App.jswith anything. Without this PR changes would not propagate on screen.To verify addendum to this change (error recovery):
App.jsthrow new Error('no')within theAppcomponent, compilation should show the error overlayAppshould HMR properly without forced refreshAppshould HMR properly without forced refreshThis should:
Fixes #9904
Fixes #9913
Fixes #9984
Fixes Partially #10078
Fixes #10287
Fixes #10539
Fixes #10606
Fixes #11087