Fixing Internal Links #5552
Fixing Internal Links #5552
Conversation
Internal links, like those found on [Available Scripts](https://facebook.github.io/create-react-app/docs/available-scripts) use absolute urls and therefore link to https://facebook.github.io/docs/deployment instead of https://facebook.github.io/create-react-app/docs/deployment.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@ehfeng Tried running locally, its working for me. Can you please share the error ? Steps for running locally : |
| @@ -8,7 +8,7 @@ sidebar_label: Adding CSS Modules | |||
|
|
|||
| This project supports [CSS Modules](https://github.com/css-modules/css-modules) alongside regular stylesheets using the `[name].module.css` file naming convention. CSS Modules allows the scoping of CSS by automatically creating a unique classname of the format `[filename]\_[classname]\_\_[hash]`. | |||
|
|
|||
| > **Tip:** Should you want to preprocess a stylesheet with Sass then make sure to [follow the installation instructions](/docs/adding-a-sass-stylesheet) and then change the stylesheet file extension as follows: `[name].module.scss` or `[name].module.sass`. | |||
| > **Tip:** Should you want to preprocess a stylesheet with Sass then make sure to [follow the installation instructions](docs/adding-a-sass-stylesheet) and then change the stylesheet file extension as follows: `[name].module.scss` or `[name].module.sass`. | |||
There was a problem hiding this comment.
Changing to docs/adding-a-sass-stylesheet makes the link become relative and the result is https://facebook.github.io/docs/docs/adding-a-sass-stylesheet which is still wrong.
Change to [follow the installation instructions](adding-a-sass-stylesheet.md) and see if it works.
|
Thanks @absrivastava. It's working for me now too. Late night, not sure why it didn't work. |
|
I reran the Travis build, green now, not sure why it was error before. Ok to merge? Can we push the latest Docusaurus to GitHub pages after merge? (A few PR's have come in after the initial push.) Wondering if I should do that? Let me know, would follow https://docusaurus.io/docs/en/publishing#using-github-pages |
* Fixing Internal Links Internal links, like those found on [Available Scripts](https://facebook.github.io/create-react-app/docs/available-scripts) use absolute urls and therefore link to https://facebook.github.io/docs/deployment instead of https://facebook.github.io/create-react-app/docs/deployment. * changing to markdown links and fixing various broken internal links
Internal links, like those found on Available Scripts
use absolute urls and therefore link to https://facebook.github.io/docs/deployment instead of
https://facebook.github.io/create-react-app/docs/deployment.
This fix is based on what I read here. I attempted to build the docs locally but couldn't figure out how.