Bump version of Verdaccio (#7787)

facebook · Jun 20, 2020 · fdbde1f · fdbde1f
1 parent 697dffe
commit fdbde1f
Show file tree

Hide file tree

Showing 7 changed files with 516 additions and 521 deletions.
diff --git a/azure-pipelines-test-job.yml b/azure-pipelines-test-job.yml
@@ -8,8 +8,6 @@ parameters:
   configurations:
     LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
     LinuxNode12: { vmImage: 'ubuntu-16.04', nodeVersion: 12.x }
-    # WindowsNode10: { vmImage: 'windows-latest', nodeVersion: 10.x }
-    # WindowsNode12: { vmImage: 'windows-latest', nodeVersion: 12.x }
 
 jobs:
   - job: ${{ parameters.name }}

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -12,8 +12,6 @@ variables:
   NPM_CONFIG_CACHE: $(Build.SourcesDirectory)/../npm-cache
   # Sets TEMP to be on the same drive as the cloned source on Windows. This avoids test scripts that "cd" into a directory under TEMP from failing because this directory is on a different drive from the current directory.
   VSTS_OVERWRITE_TEMP: True
-  # Override Verdaccio package to use. This is temporary and is needed to avoid socket timeouts on hosted Windows agent (on Azure). This also changes Verdaccio to return a 503 (service unavailable) instead of a 404 (not found) when the connection to the uplink timesout.
-  VERDACCIO_PACKAGE: https://github.com/willsmythe/verdaccio/releases/download/create-react-app/verdaccio-4.0.0-alpha.8.tgz
   CRA_INTERNAL_TEST: true
 
 # ******************************************************************************
@@ -59,10 +57,10 @@ jobs:
       configurations:
         LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
         LinuxNode12: { vmImage: 'ubuntu-16.04', nodeVersion: 12.x }
-        # WindowsNode10: { vmImage: 'windows-latest', nodeVersion: 10.x }
-        # WindowsNode12: { vmImage: 'windows-latest', nodeVersion: 12.x }
-        MacNode10: { vmImage: 'macOS-latest', nodeVersion: 10.x }
-        MacNode12: { vmImage: 'macOS-latest', nodeVersion: 12.x }
+        WindowsNode10: { vmImage: 'windows-2019', nodeVersion: 10.x }
+        WindowsNode12: { vmImage: 'windows-2019', nodeVersion: 12.x }
+        MacNode10: { vmImage: 'macOS-10.15', nodeVersion: 10.x }
+        MacNode12: { vmImage: 'macOS-10.15', nodeVersion: 12.x }
 
   # ******************************************************************************
   # Old Node test suite

diff --git a/docusaurus/docs/deployment.md b/docusaurus/docs/deployment.md
diff --git a/docusaurus/docs/measuring-performance.md b/docusaurus/docs/measuring-performance.md
@@ -49,7 +49,7 @@ reportWebVitals(sendToAnalytics);
 > **Note:** If you use Google Analytics, use the `id` value to make it easier to construct metric distributions manually (to calculate percentiles, etc…).
 >
 > ```js
-> function sendToAnalytics({id, name, value}) {
+> function sendToAnalytics({ id, name, value }) {
 >   ga('send', 'event', {
 >     eventCategory: 'Web Vitals',
 >     eventAction: name,
@@ -58,7 +58,7 @@ reportWebVitals(sendToAnalytics);
 >     nonInteraction: true, // avoids affecting bounce rate
 >   });
 > }
-> 
+>
 > reportWebVitals(sendToAnalytics);
 > ```
 >

diff --git a/packages/cra-template/template/src/reportWebVitals.js b/packages/cra-template/template/src/reportWebVitals.js
@@ -1,13 +1,13 @@
-const reportWebVitals = (onPerfEntry) => {
+const reportWebVitals = onPerfEntry => {
   if (onPerfEntry && onPerfEntry instanceof Function) {
     import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => {
-      getCLS(onPerfEntry);  
+      getCLS(onPerfEntry);
       getFID(onPerfEntry);
       getFCP(onPerfEntry);
       getLCP(onPerfEntry);
       getTTFB(onPerfEntry);
     });
   }
-}
+};
 
 export default reportWebVitals;
diff --git a/tasks/local-registry.sh b/tasks/local-registry.sh
@@ -3,7 +3,7 @@
 custom_registry_url=http://localhost:4873
 original_npm_registry_url=`npm get registry`
 original_yarn_registry_url=`yarn config get registry`
-default_verdaccio_package=verdaccio@3.8.2
+default_verdaccio_package=verdaccio@^4.5.1
 
 function startLocalRegistry {
   # Start local registry
@@ -16,9 +16,6 @@ function startLocalRegistry {
   # Set registry to local registry
   npm set registry "$custom_registry_url"
   yarn config set registry "$custom_registry_url"
-
-  # Login so we can publish packages
-  (cd && npx npm-auth-to-token@1.0.0 -u user -p password -e user@example.com -r "$custom_registry_url")
 }
 
 function stopLocalRegistry {

diff --git a/tasks/verdaccio.yaml b/tasks/verdaccio.yaml
@@ -25,6 +25,8 @@ uplinks:
     timeout: 60s
     agent_options:
       keepAlive: true
+      # Avoid exceeding the max sockets that are allocated per VM.
+      # https://docs.microsoft.com/en-us/azure/app-service/app-service-web-nodejs-best-practices-and-troubleshoot-guide#my-node-application-is-making-excessive-outbound-calls
       maxSockets: 40
       maxFreeSockets: 10
 
@@ -52,7 +54,7 @@ packages:
 
 # log settings
 logs:
-  - {type: stdout, format: pretty, level: warn}
+  - { type: stdout, format: pretty, level: warn }
   #- {type: file, path: verdaccio.log, level: info}
 
 # See https://github.com/verdaccio/verdaccio/issues/301