Convert WebpackDevServerUtils.createCompiler to take in options arg

facebook · Feb 17, 2019 · 007e6fd · 007e6fd
1 parent 7ecde96
commit 007e6fd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/packages/react-dev-utils/WebpackDevServerUtils.js b/packages/react-dev-utils/WebpackDevServerUtils.js
@@ -101,15 +101,15 @@ function printInstructions(appName, urls, useYarn) {
   console.log();
 }
 
-function createCompiler(
-  webpack,
-  config,
+function createCompiler({
   appName,
+  config,
+  devSocket,
   urls,
   useYarn,
   useTypeScript,
-  devSocket
-) {
+  webpack,
+}) {
   // "Compiler" is a low-level interface to Webpack.
   // It lets us listen to some events and provide our own custom messages.
   let compiler;

diff --git a/packages/react-scripts/scripts/start.js b/packages/react-scripts/scripts/start.js
@@ -103,15 +103,15 @@ checkBrowsers(paths.appPath, isInteractive)
         devServer.sockWrite(devServer.sockets, 'errors', errors),
     };
     // Create a webpack compiler that is configured with custom messages.
-    const compiler = createCompiler(
-      webpack,
-      config,
+    const compiler = createCompiler({
       appName,
+      config,
+      devSocket,
       urls,
       useYarn,
       useTypeScript,
-      devSocket
-    );
+      webpack,
+    });
     // Load proxy config
     const proxySetting = require(paths.appPackageJson).proxy;
     const proxyConfig = prepareProxy(proxySetting, paths.appPublic);