[2.4.*] Fix MakeViewVariableOptionalSolution to disallow stream wrappers and files that do not end in .blade.php #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ignition-contracts
The highlight package is no longer needed.
Update CHANGELOG.md
Add PHP 8 support
Super minor, I know...
Co-authored-by: Alex Pestell <me@alexpestell.com>
…files that do not end in .blade.php (facade#334) * Disallow paths with a scheme in MakeViewVariableOptionalSolution * Added a test unit for the solution * Refactored code into a isSafePath() method * Update MakeViewVariableOptionalSolution.php Co-authored-by: cfreal <folcharles@ŋmail.com> Co-authored-by: Freek Van der Herten <freek@spatie.be>
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 9.15.10 to 10.4.1. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md) - [Commits](highlightjs/highlight.js@9.15.10...10.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* use livewire version of compiler engine if livewire present * fixed class_exists to look for the right thing
Added support for the Nova text editor (nova.app) and updated the config comments to include it in the list of options.
- Add optional log recorder limit to prevent memory leaks. Especially noticable during long running tasks or daemons. - Rewrote query recorder to not tigthly couple it with the framework container when deciding whether to include bindings or limit the maximum query count that is recorded. - Added a config flag to disable log recording all together. - Made sure that query and log recorders are not used when their enable flag is disabled.
facade/ignition#302: Fix memory leaks caused by log and query recorder
…aste-bug facade#344: Fix wrong config usage
…files that do not end in .blade.php This is already fixed in 2.5.2, See facade#334 I could not update to 2.5.2 due to some dependent package required php 7.3, currently clients site is running in php 7.2 On branch 2.4.1-branch Changes to be committed: modified: src/Solutions/MakeViewVariableOptionalSolution.php
|
Hey, does this fix a general bug on the latest version or is this something meant for the |
|
Hi there, Yes, this pull request is for 2.4.x branch and related to previous PR. Also don't upgrade facade/ignition-contracts package for this branch, that required latest version of PHP, I had set version to As requested I added tests and refactor code, hope this could work. |
AlexVanderbist
changed the title
|
Hi again! Thanks for adding tests and clarifying. Can you change the PR or recreate it to merge into the 2.4.* branch instead of master? 2.4.* branch is https://github.com/facade/ignition/tree/2.4.x |
|
I changed target branch as requested, does this work? |
|
Closing this due to too much unrelated changes in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am getting error for passing null value to function that requires string.
previous pull request #356