Return output of filterReportsCallable #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jellyfrog
force-pushed
the
feat/move-filterReportsCallable
branch
from
f646736
to
80e818d
Compare
Jellyfrog
changed the title
Current code will populate Flare::sentReports() even if it's filtered since the return from sendReportToApi() is not used: $this->sendReportToApi($report); return $report; This is a regression from facade#33
Jellyfrog
force-pushed
the
feat/move-filterReportsCallable
branch
from
80e818d
to
45b9b2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code will populate Flare::sentReports() even if it's filtered since the return from sendReportToApi() is not used:
This is a regression from #33, sorry about that