drop unused constructors #5941
drop unused constructors #5941
Conversation
| @@ -34,10 +34,6 @@ public ConfigMapLock(String configMapNamespace, String configMapName, String ide | |||
| super(configMapNamespace, configMapName, identity); | |||
| } | |||
|
|
|||
| public ConfigMapLock(ObjectMeta meta, String identity) { | |||
There was a problem hiding this comment.
these two constructors does not seem to be used, so I decided to drop them. This will be a breaking change if the next release is not a major one, though. I am not sure what is the policy in this project about that.
There was a problem hiding this comment.
Usually we deprecate stuff like this first in next minor release and then remove it in follow up releases. If this class is directly exposed to users of KubernetesClient API, we would want to deprecate it first, add required JavaDocs and notice about deprecation in CHANGELOG.
There was a problem hiding this comment.
understood, we kind of do the same thing in spring... I'll change the code in that regard. thank you
There was a problem hiding this comment.
these two constructors does not seem to be used
This is part of a public facing API. How are you aware of the lack of usage of these constructors on downstream lock suppliers?
There was a problem hiding this comment.
you're right, I'm not. The thing is, on some other issue a while back, we talked about how breaking changes are somehow OK in this project, since k8s does not maintain backwards compatibility...
But as said, I'll listen to your advices, since I don't know how things are handled here. In spring, we deprecate, and remove in the next major release.
|
No description provided.