New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC: MockWebServer based on Vert.x #5632
base: main
Are you sure you want to change the base?
Conversation
7f96c77
to
492d898
Compare
Build seems to be failing because tests haven't been updated to remove okhttp mockwebserver references |
Maybe it wasn't clear by the description, but this is just WIP. Once I finish with the initial module I'll start by sending a PR to update the tests from OkHttp to Vert.x while still preserving the OkHttp production code. This way, subsequent PRs will be easier to review since tests won't (shouldn't) need updating. |
492d898
to
c28e555
Compare
c28e555
to
54af263
Compare
006ddb1
to
402c179
Compare
d44ed9c
to
79026a2
Compare
79026a2
to
dbd1971
Compare
a2c396f
to
212847c
Compare
ab8a538
to
c7be413
Compare
751fcd6
to
ce21155
Compare
0178041
to
a3b901a
Compare
a3b901a
to
2bc64e4
Compare
Quality Gate failedFailed conditions 66.7% Coverage on New Code (required ≥ 80%) |
2bc64e4
to
a1cb32d
Compare
Quality Gate failedFailed conditions |
d4aa2a0
to
1d46f9d
Compare
c917483
to
427860c
Compare
Quality Gate failedFailed conditions |
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Signed-off-by: Marc Nuri <marc@marcnuri.com>
…rver Signed-off-by: Marc Nuri <marc@marcnuri.com>
427860c
to
e75f593
Compare
Description
WIP Still working on this, but it seems that there is a viable solution with not that many breaking changes. However, it seems reasonable that this will deserve a major version change, or some tooling to help users upgrade.
Replaces the
io.fabric8:mockwebserver
module backend from OkHTTP to Vert.x.Relates to:
Type of change
test, version modification, documentation, etc.)
Checklist