Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: MockWebServer based on Vert.x #5632

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

manusa
Copy link
Member

@manusa manusa commented Dec 4, 2023

Description

WIP Still working on this, but it seems that there is a viable solution with not that many breaking changes. However, it seems reasonable that this will deserve a major version change, or some tooling to help users upgrade.

Replaces the io.fabric8:mockwebserver module backend from OkHTTP to Vert.x.

Relates to:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added the wip label Dec 4, 2023
@manusa manusa self-assigned this Dec 4, 2023
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 2 times, most recently from 7f96c77 to 492d898 Compare December 4, 2023 14:01
@rohanKanojia
Copy link
Member

Build seems to be failing because tests haven't been updated to remove okhttp mockwebserver references

@manusa
Copy link
Member Author

manusa commented Dec 12, 2023

Build seems to be failing because tests haven't been updated to remove okhttp mockwebserver references

Maybe it wasn't clear by the description, but this is just WIP.
So far only the mockwebserver module has been changed. I still need to migrate some of the tests there to use a different HTTP client instead of OkHttp. The core ones have already been updated and prove that the Mock server preserves the behavior after removing OkHttp.

Once I finish with the initial module I'll start by sending a PR to update the tests from OkHttp to Vert.x while still preserving the OkHttp production code. This way, subsequent PRs will be easier to review since tests won't (shouldn't) need updating.

@manusa manusa mentioned this pull request Dec 12, 2023
11 tasks
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 5 times, most recently from 006ddb1 to 402c179 Compare December 22, 2023 14:02
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 3 times, most recently from d44ed9c to 79026a2 Compare December 22, 2023 17:51
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 6 times, most recently from a2c396f to 212847c Compare January 4, 2024 11:09
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 4 times, most recently from ab8a538 to c7be413 Compare January 17, 2024 16:34
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 2 times, most recently from 751fcd6 to ce21155 Compare January 19, 2024 17:14
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 6 times, most recently from 0178041 to a3b901a Compare January 24, 2024 06:37
@manusa manusa mentioned this pull request Jan 25, 2024
11 tasks
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
67.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@manusa manusa force-pushed the feat/mockwebserver-vertx branch 3 times, most recently from d4aa2a0 to 1d46f9d Compare April 11, 2024 04:04
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 2 times, most recently from c917483 to 427860c Compare April 30, 2024 12:42
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
66.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

manusa added 3 commits May 9, 2024 09:41
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Signed-off-by: Marc Nuri <marc@marcnuri.com>
…rver

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa force-pushed the feat/mockwebserver-vertx branch from 427860c to e75f593 Compare May 9, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants