Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #5298: using an invalid token to trigger refresh #5311

Merged
merged 2 commits into from
Jul 14, 2023
Merged

fix #5298: using an invalid token to trigger refresh #5311

merged 2 commits into from
Jul 14, 2023

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Jul 5, 2023

Description

Opted for a simple fix initially - in situations where a token is expected, we'll initially send an invalid one.

The other options are to introduce a blocking call into before, or change the before handling to be async - neither seem to be great options, especially if this is considered for a backport.

We could more broadly address this with issues such as #4704 or capture something new.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia
Copy link
Member

@shawkins : Could you please address minor conflict?

@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.8.0 milestone Jul 14, 2023
@manusa manusa merged commit 2840d59 into fabric8io:master Jul 14, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shawkins @rohanKanojia @manusa @oscerd