Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3489: Migrated zjsonpatch from io.fabric8 to com.flipkart.zjsonpatch. Bumped version to 0.4.13 #4700

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattnelson
Copy link

@mattnelson mattnelson commented Dec 19, 2022

Description

fix #3489: Migrated zjsonpatch from io.fabric8(archived) to com.flipkart.zjsonpatch.
Bumped to latest version, 0.4.13

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@mattnelson mattnelson changed the title fix #3489: Switch to non-forked zjsonpatch fix #3489: Migrated zjsonpatch from io.fabric8 to com.flipkart.zjsonpatch. Bumped version to 0.4.13 Dec 19, 2022
@mattnelson
Copy link
Author

  • I tested my code in Kubernetes

Are there more docs on the expectations of the k8s testing cluster?
https://github.com/fabric8io/kubernetes-client/blob/master/CONTRIBUTING.md#check-your-work-after-running-all-unit-and-regression-tests

@@ -37,7 +37,7 @@
<bundle dependency='true'>mvn:org.ow2.asm/asm-tree/${asm.bundle.version}</bundle>
<bundle dependency='true'>mvn:org.ow2.asm/asm-util/${asm.bundle.version}</bundle>
<bundle dependency='true'>mvn:io.fabric8/kubernetes-model-common/${project.version}</bundle>
<bundle>mvn:io.fabric8/zjsonpatch/${zjsonpatch.version}</bundle>
<bundle>mvn:com.flipkart.zjsonpatch/zjsonpatch/${zjsonpatch.version}</bundle>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a dependency tag added?

    <bundle dependency='true'>mvn:com.flipkart.zjsonpatch/zjsonpatch/${zjsonpatch.version}</bundle>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical CVE CVE-2017-7525 in zjsonpatch-0.3.0.jar
1 participant