Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4673 ensures token is shared by the same logical instance #4679

Merged
merged 1 commit into from Dec 15, 2022
Merged

fix #4673 ensures token is shared by the same logical instance #4679

merged 1 commit into from Dec 15, 2022

Conversation

shawkins
Copy link
Contributor

Description

Partially address #4673 - it at least addresses the regression that was introduced by changing how the RequestConfig was passed down.

The other two cases - making requests smarter about waiting for an existing auth request, or sharing across possible instances of the OpenShift client haven not been addressed. These are not new to 6.x.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins added this to the 6.3.1 milestone Dec 14, 2022
@shawkins
Copy link
Contributor Author

@manusa this should be considered for 6.3.1 as well.

@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 1bd8e0e into fabric8io:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shawkins @manusa @oscerd