Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4363: refining patch logic and adding metadata compare utility #4647

Merged
merged 1 commit into from Dec 12, 2022
Merged

fix #4363: refining patch logic and adding metadata compare utility #4647

merged 1 commit into from Dec 12, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Dec 7, 2022

Description

Resolves #4363 by exposing ResourceCompare.metadataChanged - a user can use that method along with an equality check of the generation or the spec to determine just exactly what if anything has been modified about a resource. Since ObjectMetadata supports an equality method, it does not seem necessary to bring the diffing logic into the api - but I did make some small refinements to that as well.

As explained in the issue it seems like a good idea to deprecate the existing ResourceCompare methods.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins
Copy link
Contributor Author

shawkins commented Dec 7, 2022

cc @csviri

@manusa manusa added this to the 6.3.0 milestone Dec 12, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

88.0% 88.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit cd1cd06 into fabric8io:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

Api methods related to patch generation
2 participants
@shawkins @manusa