Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making raw/generic buildable #4615

Merged
merged 6 commits into from Dec 5, 2022
Merged

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Nov 28, 2022

Description

Fix #4540

This addresses #4540 as much as we can on the fabric8 side, it will allow the use of generic or raw extension in builders methods that expect a kubernetesresource.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins force-pushed the raw_buildable branch 2 times, most recently from 2874ea0 to 005c621 Compare November 28, 2022 19:43
@manusa manusa added this to the 6.3.0 milestone Nov 30, 2022
@manusa
Copy link
Member

manusa commented Nov 30, 2022

Change looks good, but I think we're missing adding the profile to the Makefiles or somewhere else. Consider that the gobuild.yml workflow ensures that whenever there are changes in the models, the generated files are persisted too.

Maybe also document about this new Maven profile in https://github.com/fabric8io/kubernetes-client/blob/f5524268e410560cd44eb86c7bb8ee44327f7c39/kubernetes-model-generator/README.md.

@shawkins
Copy link
Contributor Author

Maybe also document about this new Maven profile

The profile is not new, it's the one that's already used for the kubernetes-model-generator. I had assumed the extension make files would have just been copied from there, but alas they were not - thus the missing profile. I'll update the make files.

@manusa
Copy link
Member

manusa commented Nov 30, 2022

The profile is not new,

image

Apparently I created those 🤣

I had assumed the extension make files would have just been copied from there, but alas they were not

No, they were not. There's been multiple actions to bring them together in the past, but the process is still ongoing. This seems to be a further step in completing the task. 😌

@shawkins
Copy link
Contributor Author

shawkins commented Dec 2, 2022

@manusa should be good now

@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 7a50ed5 into fabric8io:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder methods expecting HasMetadata/KubernetesResource are not correct
2 participants