New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making raw/generic buildable #4615
Conversation
2874ea0
to
005c621
Compare
005c621
to
c903156
Compare
Change looks good, but I think we're missing adding the profile to the Makefiles or somewhere else. Consider that the gobuild.yml workflow ensures that whenever there are changes in the models, the generated files are persisted too. Maybe also document about this new Maven profile in https://github.com/fabric8io/kubernetes-client/blob/f5524268e410560cd44eb86c7bb8ee44327f7c39/kubernetes-model-generator/README.md. |
The profile is not new, it's the one that's already used for the kubernetes-model-generator. I had assumed the extension make files would have just been copied from there, but alas they were not - thus the missing profile. I'll update the make files. |
Apparently I created those 🤣
No, they were not. There's been multiple actions to bring them together in the past, but the process is still ongoing. This seems to be a further step in completing the task. 😌 |
@manusa should be good now |
SonarCloud Quality Gate failed. |
Description
Fix #4540
This addresses #4540 as much as we can on the fabric8 side, it will allow the use of generic or raw extension in builders methods that expect a kubernetesresource.
Type of change
test, version modification, documentation, etc.)
Checklist