[crd-generator] Fix inconsistent additionalPrinterColumns jsonPath #4614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaTP
commented
Nov 28, 2022
| @@ -40,41 +42,42 @@ public AddAdditionPrinterColumnDecorator(String name, String version, String typ | |||
|
|
|||
| @Override | |||
| public void andThenVisit(CustomResourceDefinitionVersionFluent<?> spec) { | |||
| Predicate<CustomResourceColumnDefinitionBuilder> matchingColumn = col -> col.getName() != null && col.getName().equals(columnName); | |||
| Predicate<CustomResourceColumnDefinitionBuilder> matchingColumn = col -> col.getName() != null | |||
| && col.getName().equals(columnName) && col.getJsonPath() != null && col.getJsonPath().equals(path); | |||
There was a problem hiding this comment.
Just highlighting the "real change" in this PR.
There was a problem hiding this comment.
Perhaps we should issue a warning when we encounter such a situation?
There was a problem hiding this comment.
I checked the behavior, and it looks consistent to me without the need for a warning.
Using the "Joke" CRD used in the tests and created a corresponding "Joke" CR:
apiVersion: "samples.javaoperatorsdk.io/v1alpha1"
kind: JokeRequest
metadata:
name: jr-any
spec:
category: Any
status:
category: Punthe output of kubectl get seems fine to me:
lburgazzoli
approved these changes
Nov 28, 2022
|
rebased and now this diff looks great 🙂 cc. @manusa |
|
SonarCloud Quality Gate failed. |
manusa
approved these changes
Nov 30, 2022
manusa
added
the
changelog missing
manusa
removed
the
changelog missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a proposal to fix #4610
After this fix,
additionalPrinterColumnswith different paths will be emitted with colliding names. I'm not sure if this has implications.Type of change
test, version modification, documentation, etc.)
Checklist