Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CertUtils.handleOtherKeys() behavior with Cavium #4556

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Fixed CertUtils.handleOtherKeys() behavior with Cavium #4556

merged 2 commits into from
Nov 15, 2022

Commits on Nov 2, 2022

  1. Do not reuse KeyFactory instance after a failure. 

    Fixes fabric8io#4509

This took a while to find the root cause:

The internal SPI fallback logic inside `KeyFactory.generatePrivate()`
has the weird side effect of latching onto the LAST registered provider
(which in our case was Cavium) after `InvalidKeySpecException` is thrown.

This choice is sticky for a single instance of KeyFactory and the fix
for our issue is to get fresh `KeyFactory` instance when retrying.
    @sfc-gh-jkowalski
    sfc-gh-jkowalski committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    2e35a68 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. ran mvn spotless:apply

    @sfc-gh-jkowalski
    sfc-gh-jkowalski committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    292d45a View commit details
    Browse the repository at this point in the history