Fix 4535 - support file uploads with filenames containing single quote

[BrianDevC]

Description

Fix #4535

Single quotes in folder or file names were causing corruption of the shell command. The fix changes the ' character to '"'"'
For example a folder called te'st would now get shellQuoted to 'te'"'"'st'

1. ' ends the first quote,
2. " starts second quote,
3. ' is valid character in double quotes
4. " ends the second quote
5. ' starts the third quote
6. The end result when fed into the shell, is as we desired: te'st

#4535

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[shawkins]

Looks good. It's also possible to just change \\\\ to be \\. Can you add/modify a test to PodIT.uploadFile? - there's one there already with a bunch of special chars, but not a single quote.

[BrianDevC]

Looks good. It's also possible to just change \\ to be \. Can you add/modify a test to PodIT.uploadFile? - there's one there already with a bunch of special chars, but not a single quote.

I tried that but didn't get the results I expected.
Now trying it again it works just fine. Perhaps my sanity is leaving me. I'll re-patch to that. Adding a new assertion to the test you suggested.

[BrianDevC]

The code smells look to be A, not caused by my changes and B, fairly simple to fix. (Change throwable to exception.)

I'm happy to go ahead and commit that assuming tests still pass to keep it happy but am I alright to do so under this issue? Don't know your policy on lumping technically different issues together under the same number. :)

[shawkins]

I'm happy to go ahead and commit that assuming tests still pass to keep it happy but am I alright to do so under this issue?

Sonar isn't perfect so it can find stuff that is out of scope or false positives. It won't hold up this pr to have code check failing, @manusa will merge it regardless.

If you'd like to address these, I don't have a problem with that.

Don't know your policy on lumping technically different issues together under the same number. :)

As long as they are this straight-forward, it's fine to have them under the same PR. As separate commits would be best.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

9.1% Coverage
0.0% Duplication