Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serverSideApply dsl support #4531

Merged
merged 1 commit into from
Nov 15, 2022
Merged

serverSideApply dsl support #4531

merged 1 commit into from
Nov 15, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Oct 25, 2022

Description

Implementation of serverSideApply described in #4524 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

78.0% 78.0% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.3.0 milestone Nov 15, 2022
@manusa manusa merged commit fc0bda5 into fabric8io:master Nov 15, 2022
@bachmanity1
Copy link
Contributor

bachmanity1 commented Mar 17, 2023

It looks like it's not possible to test this method with a mock server using @EnableKubernetesMockClient(crud = true). The mock server returns 404 error unless resource is created in advance. This behavior doesn't match the behavior of real k8s server which doesn't return an error but creates a resource if it doesn't already exist.

@bachmanity1
Copy link
Contributor

It looks like it's not possible to test this method with mock server using @EnableKubernetesMockClient(crud = true). Mock server returns 404 error unless resource is created in advance. This behavior doesn't match behavior of real k8s server which doesn't return error but creates a resource if doesn't already exist.

actually, this doesn't work even if a resource is created in advance. I get Unsupported Media Type error.

io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: PATCH at: 
https://localhost:60043/apis/foo/v1/namespaces/test/foos/test?fieldManager=fabric8&force=true. Message: Unsupported 
Media Type. Received status: Status(apiVersion=v1, code=415, details=StatusDetails(causes=[], group=null, 
kind=Unknown, name=null, retryAfterSeconds=null, uid=null, additionalProperties={}), kind=Status, 
message=Unsupported Media Type, metadata=null, reason=Invalid, status=Failure, additionalProperties={}).

@shawkins
Copy link
Contributor Author

actually, this doesn't work even if a resource is created in advance. I get Unsupported Media Type error.

The crud mock server does not support server side apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants